Make cache-write failures non-fatal #12302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
bug
|
One sec, making some changes. |
charliermarsh
force-pushed
the
charlie/caches
branch
from
9f5e704
to
4b8a7d2
Compare
charliermarsh
commented
Jul 12, 2024
| self.path.display() | ||
| ) | ||
| })?; | ||
| if let Err(err) = temp_file.persist(&self.path) { |
There was a problem hiding this comment.
The open method on this struct already uses a similar pattern of warning (but ignoring) some errors.
charliermarsh
force-pushed
the
charlie/caches
branch
from
4b8a7d2
to
ba0831b
Compare
|
zanieb
approved these changes
Jul 12, 2024
|
Should we be retrying like we do in uv? |
|
I don't think we should in this case because it's not a guard against anti-virus stuff like with binaries; it's a guard against the file being in-use, and it's not clear how long we'd expect that to be true or whether we should expect it to resolve. |
|
Thanks for the fast fix (and the fast release cadence so I don't have to inquire about when we might get the fix)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12284.